[DRAFT (WIP)] Add integration script for ruby 3.1 #1563
+253
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
ruby-integration
branch
2 times, most recently
from
aa00d22
to
03b8ff6
Compare
| pushd ${branch} | ||
| ./autogen.sh | ||
| mkdir -p build && cd build | ||
| ../configure --with-openssl-dir=${AWS_LC_INSTALL_FOLDER} \ |
There was a problem hiding this comment.
minor nit: you can use the -C flag for make to specify a directory instead of cding into build
| ../configure --with-openssl-dir=${AWS_LC_INSTALL_FOLDER} \ | ||
| --with-openssl-lib=${AWS_LC_INSTALL_FOLDER}/lib \ | ||
| --with-openssl-include=${AWS_LC_INSTALL_FOLDER}/include | ||
| make -j ${NUM_CPU_THREADS} |
There was a problem hiding this comment.
after the build (and tests), we should be able to ensure that we're linked against AWS-LC with
$ ruby -e 'require "openssl"; puts OpenSSL::OPENSSL_VERSION'
OpenSSL 1.0.2k 26 Jan 2017
771ff8c
to
0d9098b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 78.49% 78.48% -0.02%
==========================================
Files 585 585
Lines 99630 99652 +22
Branches 14254 14257 +3
==========================================
+ Hits 78206 78209 +3
- Misses 20789 20807 +18
- Partials 635 636 +1 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
ruby-integration
branch
3 times, most recently
from
6cf2b3d
to
365401c
Compare
samuel40791765
force-pushed
the
ruby-integration
branch
2 times, most recently
from
f69869d
to
26b722a
Compare
samuel40791765
force-pushed
the
ruby-integration
branch
from
26b722a
to
85edc6b
Compare
(cherry picked from commit f8a47bb166c73cebeaa412844b901bfd4846b51f)
samuel40791765
force-pushed
the
ruby-integration
branch
from
85edc6b
to
6bacec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We're nowhere near full support for Ruby, but here's a script to test this in our CI once we have it.
Call-outs:
WIP
Testing:
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.