Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCSP timebomb in tests #1891

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

samuel40791765
Copy link
Contributor

@samuel40791765 samuel40791765 commented Sep 30, 2024

Issues:

Resolves #1889

It turns out the first call to OCSP_check_validity in TestGoodOCSP will emit two additional errors on to the error stack once the "this update" field is outdated. Clearing the previous additional errors on the stack allows us to check for which specific errors were emitted more accurately.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 force-pushed the fix-ocsp-timebomb branch 4 times, most recently from a5741ac to f957348 Compare September 30, 2024 22:01
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (36e0307) to head (7bfa580).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
- Coverage   78.50%   78.46%   -0.05%     
==========================================
  Files         585      585              
  Lines       99516    99518       +2     
  Branches    14244    14243       -1     
==========================================
- Hits        78122    78083      -39     
- Misses      20759    20799      +40     
- Partials      635      636       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 force-pushed the fix-ocsp-timebomb branch 6 times, most recently from b5d3004 to 9a6754d Compare October 1, 2024 02:38
@samuel40791765 samuel40791765 changed the title Fix and add CI for potential testing timebombs Fix OCSP timebomb in tests Oct 1, 2024
@samuel40791765 samuel40791765 marked this pull request as ready for review October 1, 2024 02:39
@samuel40791765 samuel40791765 requested a review from a team as a code owner October 1, 2024 02:39
@samuel40791765 samuel40791765 force-pushed the fix-ocsp-timebomb branch 3 times, most recently from 9a6754d to 4af07fc Compare October 1, 2024 23:07
@samuel40791765 samuel40791765 enabled auto-merge (squash) October 1, 2024 23:33
@samuel40791765 samuel40791765 merged commit ff56e55 into aws:main Oct 2, 2024
106 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future test error in OCSPTest.TestGoodOCSP
4 participants