Remove duplicate s2n-bignum prefix include option #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
approved these changes
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
=======================================
Coverage 78.50% 78.51%
=======================================
Files 585 585
Lines 99682 99681 -1
Branches 14262 14270 +8
=======================================
+ Hits 78260 78261 +1
+ Misses 20786 20782 -4
- Partials 636 638 +2 ☔ View full report in Codecov by Sentry. |
nebeid
approved these changes
Oct 8, 2024
andrewhop
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Accidentally added the same option twice in #1903 when invoking the pre-processor. Not fatal, but also not necessary... So, remove the duplicate option.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.