Missing functionality + Adding Nmap to our CI #1915
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1915 +/- ##
=======================================
Coverage 78.50% 78.51%
=======================================
Files 585 585
Lines 99682 99685 +3
Branches 14262 14271 +9
=======================================
+ Hits 78260 78265 +5
+ Misses 20786 20783 -3
- Partials 636 637 +1 ☔ View full report in Codecov by Sentry. |
| --exec-prefix="$NMAP_BUILD_EPREFIX" \ | ||
| --with-openssl="$AWS_LC_INSTALL_FOLDER" | ||
|
|
||
| make -j install |
There was a problem hiding this comment.
can we add a ldd check to assert that nmap is linked against AWS-LC?
| - name: Install OS Dependencies | ||
| run: | | ||
| sudo apt-get update -o Acquire::Languages=none -o Acquire::Translation=none | ||
| sudo apt-get -y --no-install-recommends install cmake gcc ninja-build golang make cairo libcario2 libcairo2-dev gir1.2-gtk-3.0 python3-gi gobject-introspection libgirepository1.0-dev |
There was a problem hiding this comment.
we shouldn't need any of the graphics-related libraries here (cairo, gtk). some also don't appear to be available on ubuntu-latest. it looks like there's a --without-zenmap build configuration option to disable GUI stuff.
This option prevents the Zenmap graphical frontend from being installed. Normally the build system checks your system for requirements such as the Python scripting language and then installs Zenmap if they are all available.
you might be able to rip out the python dependency as well.
| int BIO_destroy_bio_pair(BIO *b) { | ||
| bio_destroy_pair(b); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
Not handling a null BIO.
| @@ -106,6 +106,7 @@ static const struct { | |||
| const char* name; | |||
| } kCipherAliases[] = { | |||
There was a problem hiding this comment.
What uses these aliases? Does adding DES here enable it to be used silently by default anywhere?
Issues:
CryptoAlg-2552
Description of changes:
This PR adds Nmap tip of main to our CI. It includes:
Testing:
Locally built and ran nmap tests with AWS-LC and verified they pass. Conducted a dry run with the extra included file to ensure it doesn't break any consumers in live (refer to CryptoAlg-2552 for the dryrun link).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.