Expand ARCH check to use CMAKE_SIZEOF_VOID_P for x86 and x86_64 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinboswell
previously approved these changes
Feb 23, 2021
bryce-shang
reviewed
Feb 23, 2021
andrew-kaufman
force-pushed
the
arch-checks
branch
from
44ddbe1
to
496a02c
Compare
bryce-shang
approved these changes
Feb 23, 2021
darylmartin100
approved these changes
Feb 23, 2021
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
…er_mscv Replace static array qualifier with macro that maps to nothing if it detects an msvc compiler s2n-bignum original commit: awslabs/s2n-bignum@9e60dfc
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
…er_mscv Replace static array qualifier with macro that maps to nothing if it detects an msvc compiler s2n-bignum original commit: awslabs/s2n-bignum@9e60dfc s2n-bignum original commit: awslabs/s2n-bignum@0308bfc
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 19, 2024
…er_mscv Replace static array qualifier with macro that maps to nothing if it detects an msvc compiler s2n-bignum original commit: awslabs/s2n-bignum@9e60dfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves: CryptoAlg-671
Description of changes:
When integrating with aws-c-cal in this PR,
aws-lcfails to build in a 32-bit container running on a 64-bit host. This is becauseCMAKE_SYSTEM_PROCESSORreturns the architecture of the host and, as a result, assembly files meant for 64-bit were being included. This expands to checkCMAKE_SIZEOF_VOID_Pfor eitherx86orx86_64and updateARCHaccordingly.Call-outs:
We do not currently have a dimension in our CI that tests this behavior, but this will be added in the work for CryptoAlg-663.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.