Add Docker Delegated Consistency to Volume #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OH! Performance for my application's require went down to ~5seconds after this change. |
Resolve Docker on Mac performance issues (https://docs.docker.com/docker-for-mac/osxfs-caching/) by allowing the project folder to be mounted as both "read only" (current behavior) and "delegated".
|
OK, just pushed up some test changes which should get things green. |
|
Could you re-run the tests? The failure looks like a random one. |
|
What kind of guarantees does this affect? |
|
None that I know of, especially given the mount was read-only to begin with. Did you have a specific guarantee in mind @thesriram? |
|
After reading through https://docs.docker.com/docker-for-mac/osxfs-caching/, I am convinced that Thanks for digging through Docker and making this change. I think many customers will find this valuable, especially on Mac. |
sanathkr
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: Performance for Docker runs using
sam local start-apion Mac is horrible. I benchmarked requiring a large Ruby application at ~45seconds.FIX: Resolve Docker on Mac performance issues by allowing the project folder to be mounted as both "read only" (current behavior) and "delegated". The docs for Docker mention that a comma-separated list is an allowed value. Hence I maintained the
romode and simply addeddelegatedto the list. Doc: https://docs.docker.com/v17.09/engine/admin/volumes/volumes/Please see this article for a description of the new option added. https://docs.docker.com/docker-for-mac/osxfs-caching/. If tests pass, I assume this option being added is a noop for non Mac platforms.