Add snapcraft config and link to snap package in README #1086
Conversation
snapcraft.yaml
Outdated
|
|
||
| license: Apache-2.0 | ||
|
|
||
| base: core18 |
There was a problem hiding this comment.
This is awesome!
Does this base image have the correct glibc support? We have had issues building a snap for sam cli because of that?
Has this been tested and verified to work?
There was a problem hiding this comment.
Yes I have this working locally. I've gone through an init, package, and deploy successfully :)
|
Updated so it no longer requires strict confinement thanks to some help on snapcraft forum :) |
| @@ -0,0 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| HOME="$(getent passwd "${USER}" | cut -d: -f6)" | |||
There was a problem hiding this comment.
Just curious: Why do you need this?
There was a problem hiding this comment.
I see you've merged already but this is because, by default, within the snap's runtime $HOME is set to another folder. SAM needs access to the user's ~/.aws (granted by the personal-files plug) so we need to set $HOME to the proper folder :)
README.md
Outdated
| @@ -11,6 +11,8 @@ Status](https://travis-ci.org/awslabs/aws-sam-cli.svg?branch=develop) | |||
|  | |||
|  | |||
|
|
|||
| [](https://snapcraft.io/sam-cli) | |||
There was a problem hiding this comment.
can we change the package name to aws-sam-cli instead of sam-cli?
There was a problem hiding this comment.
Definitely and I've just got this registered (thanks @davdunc!)
snap/snapcraft.yaml
Outdated
| @@ -0,0 +1,50 @@ | |||
| name: sam-cli | |||
|
Thanks a ton for contributing this feature! Super helpful indeed. I have a few minor comments. Looks good otherwise. |
|
Actually, I made the changes I propsed myself and pushed to your branch. |
|
@stilvoid Hey did you happened to register the name |
Issue #, if available: N/A
Description of changes: Add support for snapcraft package
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.