Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding specific configuration for gradle projects using kotlin build script #1098

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Adding specific configuration for gradle projects using kotlin build script #1098

merged 1 commit into from
Apr 4, 2019

Conversation

philippeagra
Copy link
Contributor

@sanathkr
Copy link
Contributor

sanathkr commented Apr 3, 2019 •
edited
Loading

@philippeagra Thanks for submitting this change. Can you also add an integration test so we know this works now and moving forward? We should be able to take in this change after that.

@philippeagra
Copy link
Contributor Author

@sanathkr yes, it's added.

sanathkr
sanathkr approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@sanathkr sanathkr merged commit 9b71857 into aws:develop Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanathkr sanathkr sanathkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippeagra @sanathkr