-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) CloudFormation AWS::ApiGateway::Stage Support #1239
Merged
jfuss
merged 62 commits into
aws:start-api/cfn
from
viksrivat:feature/cloud_formation_stage_support
Jul 26, 2019
Merged
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
8f6b8fb
Initial setup and work
viksrivat f457401
Add RestApi tests
viksrivat 8112cf4
Remove Stage Name/Variable from pr
viksrivat 5050dd8
Run make pr
viksrivat bf5a083
Add Rest Api integration test
viksrivat 6eb226a
Remove AWS::Stage from current pr
viksrivat 7c5823d
Update integration test to only use CloudFormation types
viksrivat 4966513
Re-run Travis Ci
viksrivat 2c38ede
Update Uri to BodyS3Location
viksrivat 9d3d137
Add docstring to extract_swagger_api
viksrivat b6d9b62
Fix Merge conflicts with dev and branch
viksrivat f8ac623
Update AWS::ApiGateway::Stage tests
viksrivat 54bda7f
Test local file in body fail and clean tests
viksrivat 9b06696
Initial Attempt
viksrivat 145162e
Refactor Sam API provider
viksrivat 5615163
Cleanup Refactoring
viksrivat 752fba8
Merge pull request #1 from viksrivat/feature/cloud_formation_api_prov…
viksrivat 1157284
Update AWS::ApiGateway::Stage tests
viksrivat 5d1dfc7
Fix merge conflict
viksrivat 7ed267c
Remove .vscode
viksrivat 681ede3
Re-run travis
viksrivat a0f5837
Restructure the information Api has the way it passed through
viksrivat a3ca29f
Merge pull request #2 from viksrivat/cleanup/update_common_stage_feat…
viksrivat 0078786
Update common
viksrivat 9879105
Merge branch 'feature/cloud_formation_stage_support' of github.com:vi…
viksrivat a9117ad
Update AbstractParserProvider documentation
viksrivat 997845c
Initial Refactor refactor
viksrivat de65fd0
Fix tests and run make pr
viksrivat df243a7
Fix merge conflict
viksrivat 4555f11
Reorganize classes
viksrivat 420a842
Update docstrings
viksrivat 53f4b7e
Update the SAMBaseProvider
viksrivat 856326e
Fix merge conflict
viksrivat 6803a0b
Restructure to seperate SAM and CF providers seperately + tests
viksrivat 837137f
Remove transform flag in the rest-api
viksrivat 4130ea2
Remove BaseProvider object
viksrivat ec833dc
Fix merge conflict
viksrivat 693692b
Update with style
viksrivat 19eaebe
Update tests and code with comments
viksrivat d226f53
Fix merge conflicts with comments from feature/cfn_rest_api
viksrivat 23467de
Update tests with comments
viksrivat 7e25c02
Fix merge conflict tests
viksrivat 066b236
Trigger
viksrivat 8987db2
Remove noapievent
viksrivat 4a792bf
Update tests
viksrivat 644b851
Update merge conflictz
viksrivat 238742a
Fix bug with api
viksrivat 7662f24
Fixed comments
viksrivat cc21095
Fix merge with rest_api
viksrivat b50e644
Remove Invalid Integration Test
viksrivat a01aee2
Run make pr
viksrivat ae97479
Merge branch 'develop' into feature/cloud_formation_stage_support
viksrivat fe706c7
Fix merge issues and run make pr
viksrivat 9ea9a67
Update Route with comments
viksrivat 8353724
Fix Route collector doc
viksrivat 8b096d3
Update to run AWS::ApiGateway::Stage Integration tests
viksrivat fcfc10e
Update based on comments
viksrivat f78cbd0
Update RouteCollector to collect and create Api
viksrivat df8186f
Cleanup ApiCollector
viksrivat be44710
Update Based on Comments
viksrivat 12ce392
Update tests
viksrivat e89cc33
Update ApiCollector description
viksrivat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update Based on Comments
- Loading branch information
commit be44710fbaafdba5c97fef2705abfdcdd0d50126
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,9 +68,6 @@ def _extract_from_serverless_api(self, logical_id, api_resource, collector, cwd= | |
collector: samcli.commands.local.lib.route_collector.RouteCollector | ||
Instance of the API collector that where we will save the API information | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make sure all docstrings are updated. api is not a param and collector should be ApiCollector instead of RouteCollector |
||
api: samcli.commands.local.lib.provider.Api | ||
Instance of the Api which will save all the api configurations | ||
|
||
cwd : str | ||
Optional working directory with respect to which we will resolve relative path to Swagger file | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is not modification in this method. It is just returning the api that is 'collected/parsed'