Allow non-nil but empty headers (#2826)

* Allow non-nil but empty headers
aws · Oct 8, 2024 · aa04330 · aa04330
1 parent 5a4e5bb
commit aa04330
Show file tree

Hide file tree

Showing 47 changed files with 915 additions and 820 deletions.
diff --git a/.changelog/1a4f8663e68646a7a2f0546bf0a7fb59.json b/.changelog/1a4f8663e68646a7a2f0546bf0a7fb59.json
@@ -0,0 +1,9 @@
+{
+    "id": "1a4f8663-e686-46a7-a2f0-546bf0a7fb59",
+    "type": "bugfix",
+    "description": "Allow non-nil but empty headers",
+    "modules": [
+        "internal/protocoltest/awsrestjson",
+        "internal/protocoltest/restxml"
+    ]
+}
diff --git a/...-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsProtocolUtils.java b/...-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsProtocolUtils.java
@@ -150,8 +150,20 @@ public static void generateHttpProtocolTests(GenerationContext context) {
                         .service(ShapeId.from("aws.protocoltests.json10#JsonRpc10"))
                         .operation(ShapeId.from("aws.protocoltests.json10#OperationWithNestedStructure"))
                         .addTestName("AwsJson10ClientPopulatesNestedDefaultValuesWhenMissing")
+                        .build(),
+
+                // TODO these tests are currently failing due to tests not being updated, see #2825
+                HttpProtocolUnitTestGenerator.SkipTest.builder()
+                        .service(ShapeId.from("aws.protocoltests.restjson#RestJson"))
+                        .operation(ShapeId.from("aws.protocoltests.restjson#NullAndEmptyHeadersClient"))
+                        .addTestName("RestJsonNullAndEmptyHeaders")
+                        .build(),
+                HttpProtocolUnitTestGenerator.SkipTest.builder()
+                        .service(ShapeId.from("aws.protocoltests.restxml#RestXml"))
+                        .operation(ShapeId.from("aws.protocoltests.restxml#NullAndEmptyHeadersClient"))
+                        .addTestName("NullAndEmptyHeaders")
                         .build()
-                ));
+        ));
 
         Set<HttpProtocolUnitTestGenerator.SkipTest> outputSkipTests = new TreeSet<>(SetUtils.of(
                 // CBOR default value deserialization (SHOULD)

diff --git a/internal/protocoltest/awsrestjson/api_op_NullAndEmptyHeadersClient_test.go b/internal/protocoltest/awsrestjson/api_op_NullAndEmptyHeadersClient_test.go
diff --git a/internal/protocoltest/awsrestjson/serializers.go b/internal/protocoltest/awsrestjson/serializers.go
diff --git a/internal/protocoltest/restxml/api_op_NullAndEmptyHeadersClient_test.go b/internal/protocoltest/restxml/api_op_NullAndEmptyHeadersClient_test.go