Fix host prefix bug #2200
Merged
Fix host prefix bug #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jul 20, 2023
… filter; regen eventbridge
lucix-aws
approved these changes
Jul 20, 2023
aajtodd
approved these changes
Jul 21, 2023
| "DisableEndpointHostPrefix", SmithyGoDependency.SMITHY_HTTP_TRANSPORT).build() | ||
| ); | ||
| // we only want the content above written ONCE per operation. | ||
| written = true; |
There was a problem hiding this comment.
nit: Then just write it and break out of the loop
There was a problem hiding this comment.
right, will do, in next PR -- artifact left over from my previous logic. a break is more straightforward
isaiahvita
added a commit
to isaiahvita/aws-sdk-go-v2
that referenced
this pull request
Jul 25, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 25, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 27, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
aws/smithy-go#439