Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/credentials/plugincreds: Add support for Go plugin for credentials #1320

Merged
merged 8 commits into from
Jun 19, 2017

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jun 5, 2017

Adds support for using plugins to retrieve credentials for API requests.
This change adds a new package plugincreds under aws/credentials.

As of Go 1.8 this functionality is only available for Linux.

See the example/aws/credentials/plugincreds folder in the SDK for
example usage.

@jasdel jasdel self-assigned this Jun 5, 2017
@jasdel jasdel requested a review from xibz June 5, 2017 22:22
Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one change in the example

// go build -tags example -o usePlugin usePlugin.go
//
// Usage:
// ./usePlugin <compiled plugin file>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg is never used in the example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixed these tests.

…vider

Adds support for using plugins to retrieve credentials for API requests.
This change adds a new package plugincreds under aws/credentials.

As of Go 1.8 this functionality is only available for Linux.

See the example/aws/credentials/plugincreds folder in the SDK for
example usage.
@jasdel jasdel force-pushed the feature/PluginCredProvider branch from 2dd708a to b39a102 Compare June 7, 2017 21:54
@jasdel jasdel merged commit 834ee94 into aws:master Jun 19, 2017
@jasdel jasdel deleted the feature/PluginCredProvider branch June 19, 2017 23:10
jasdel added a commit that referenced this pull request Jun 19, 2017
@awstools awstools mentioned this pull request Jun 20, 2017
@diehlaws diehlaws added needs-review This issue or pull request needs review from a core team member. and removed review-needed labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants