aws/credentials/ec2rolecreds: Avoid unnecessary redirect #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes aws-sdk-go consistent with the other SDKs. - https://github.com/boto/boto/blob/315b76e01e65fb742cbc14170e5207d648bc649a/boto/provider.py#L390-L392 - https://github.com/aws/aws-sdk-ruby/blob/5fe5795e8910bb667996dfc75e4f16b7e69e3980/gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb#L92
xibz
suggested changes
Jul 12, 2018
|
|
||
| hasTrailing := strings.HasSuffix(elems[len(elems)-1], "/") | ||
| str := path.Join(elems...) | ||
| if hasTrailing && str != "/" { |
There was a problem hiding this comment.
shouldn't this be str[len(str)-1] != '/'?
xibz
approved these changes
Jul 12, 2018
Merged
|
I can also confirm that v1.14.26 works as expected in my use case. Before: v1.14.26: |
|
Thanks for the update @stefansundin I created aws-sdk-go-v2#198 to track this work being ported to the V2 SDK. |
SoManyHs
added a commit
to SoManyHs/amazon-ecs-cli
that referenced
this pull request
Aug 2, 2018
This account for aws/aws-sdk-go#2037
xibz
pushed a commit
to xibz/aws-sdk-go
that referenced
this pull request
Sep 12, 2018
Updates aws#2002 to preserve the trailing slash on EC2 Metadata requests. This removes the unnecessary redirect for /latest/meta-data/iam/security-credentials/.
usrenmae
pushed a commit
to usrenmae/aws-sdk-go
that referenced
this pull request
Sep 23, 2018
Updates aws#2002 to preserve the trailing slash on EC2 Metadata requests. This removes the unnecessary redirect for /latest/meta-data/iam/security-credentials/.
diehlaws
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2002 to preserve the trailing slash on EC2 Metadata requests. This removes the unnecessary redirect for
/latest/meta-data/iam/security-credentials/.