aws/request: Add additional retry tests for SerializationError #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Dec 8, 2020
skotambkar
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Should v2 not retry 502, 503, 504 status errors as v1 classifies them as throttled errors.
https://github.com/aws/aws-sdk-go/blob/master/aws/request/retryer.go#L280
Adds additional retry expectation tests for SDK's handling of SerializationError being treated as a retryable/throttling error. Related to #3649
jasdel
force-pushed
the
origin/AdditionalRetryTest
branch
from
67ec9d4
to
7e5d178
Compare
|
The concept of throttling has changed in v2, and the v2 retrier doesn't distinguish the difference between the retry and throttle. Instead opting for a token bucket approach. Where 50x errors are considered connection errors to be retried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional retry expectation tests for SDK's handling of SerializationError being treated as a retryable/throttling error.
Related to #3649