Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding concatenate objects example #846

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Adding concatenate objects example #846

merged 2 commits into from
Sep 20, 2016

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Sep 20, 2016

No description provided.

return foo.CopyPartResult.ETag, bar.CopyPartResult.ETag, nil
}

func main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to document the input parameters here also in addition to the readme.

@@ -0,0 +1,12 @@
# Example

concatenateObjects is an example using the AWS SDK for Go to concatenate two objects together.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just concatObjects for shorter name.

Copy link
Contributor

@jasdel jasdel Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would be great to describe what is going on and how UploadPartCopy can be used to concat two objects already in S3 into a new object. And mention if you can do A = A + B, or only C = A + B

Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just couple suggestions.

@xibz xibz merged commit c859f1a into aws:master Sep 20, 2016
jasdel added a commit that referenced this pull request Sep 20, 2016
@xibz xibz deleted the examples branch September 26, 2016 19:42
skotambkar added a commit to skotambkar/aws-sdk-go that referenced this pull request May 20, 2021
route53 : fix sanitizeURL customization to handle leading `/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants