-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding concatenate objects example #846
Conversation
return foo.CopyPartResult.ETag, bar.CopyPartResult.ETag, nil | ||
} | ||
|
||
func main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to document the input parameters here also in addition to the readme.
@@ -0,0 +1,12 @@ | |||
# Example | |||
|
|||
concatenateObjects is an example using the AWS SDK for Go to concatenate two objects together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just concatObjects
for shorter name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would be great to describe what is going on and how UploadPartCopy
can be used to concat two objects already in S3 into a new object. And mention if you can do A = A + B
, or only C = A + B
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just couple suggestions.
route53 : fix sanitizeURL customization to handle leading `/`
No description provided.