Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: Correct the location of the SQS example #964

Merged
merged 1 commit into from
Nov 29, 2016
Merged

example: Correct the location of the SQS example #964

merged 1 commit into from
Nov 29, 2016

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Nov 29, 2016

The example should of been under the example/service folder not directly under example.

@xibz
Copy link
Contributor

xibz commented Nov 29, 2016

LGTM, :shipit:

@jasdel jasdel merged commit b47e9ec into aws:master Nov 29, 2016
@jasdel jasdel deleted the fix/sqsMockExample branch November 29, 2016 21:43
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this pull request May 20, 2021
@jasdel
aws/signer/v4: Ensure logger option passed down to sign method (aws#964)
3fb2b0c 
Ensures the middleware's Logger option value is passed down to the signer's sign method via functional options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasdel @xibz