Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @ts-check for scripts written in JavaScript #1389

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 16, 2020

Issue #, if available:
N/A

Description of changes:
add @ts-check for scripts written in JavaScript so that we get benefits of TypeScript checking in JS files. Docs: https://www.typescriptlang.org/docs/handbook/type-checking-javascript-files.html

Screen recording

ts-check

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #1389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1389   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files         287      287           
  Lines       11150    11150           
  Branches     2358     2358           
=======================================
  Hits         8817     8817           
  Misses       2333     2333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a3975...f334448. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@trivikr trivikr merged commit b276ec1 into aws:master Jul 16, 2020
@trivikr trivikr deleted the add-ts-check branch July 16, 2020 23:17
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants