feat(smithy-client): implement SdkException class #3261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1506
#2007
Description
ServiceException
class as a base class for all the server-side exception classes. The refactor to the deserializer will come next. It implements the mostly the same interface asSdkError
.SdkError
interface is deprecated because it is not used/enforced in actual exceptions thrown from the deserializer. It cannot be changed toServiceException
class because it declares every member as optional. However, theSdkException
contains required members(message
,name
), simply keeping the name will cause breaking change to anyone consuming theSdkError
interface.SmithyExceptoin
interface is deprecated for the same reason.Testing
TBD
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.