Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update runtime plugin interface #400

Merged
merged 10 commits into from
Oct 17, 2019

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Oct 15, 2019

Description of changes:

  1. Update runtime plugin interface so it mutates the existing middleware stack from client or commands. Link

  2. Merge serialize middleware and deserializer middleware into a single serdePlugin containing the 2 middleware

  3. Generated serializer & deserializer now doesn't import any runtime-specific dependencies. Instead, we are generating transfer-protocol-specific utils interface along with serializer & deserializer. The utils value should be set inside the client config

/cc @mtdowling @srchase

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Now a plugin is a function that return a list of middlewares together
with handler options. Update some client middleware with the new plugin
interface: content length; retry; signing; user agent;
* support adding multiple middleware
* support optionally remove existing middleware before inserting new middleware
Instead, use the runtime-specific utils specified in client config
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #400 into smithy-codegen will decrease coverage by 0.25%.
The diff coverage is 25%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #400      +/-   ##
==================================================
- Coverage           96.97%   96.72%   -0.26%     
==================================================
  Files                  69       69              
  Lines                1158     1161       +3     
  Branches              213      214       +1     
==================================================
  Hits                 1123     1123              
- Misses                 35       38       +3
Impacted Files Coverage Δ
packages/retry-middleware/src/retryMiddleware.ts 63.63% <20%> (-14.15%) ⬇️
packages/signing-middleware/src/middleware.ts 80% <33.33%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf9213...045f83a. Read the comment docs.

@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Oct 15, 2019
@srchase srchase marked this pull request as ready for review October 16, 2019 19:12
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 1bb6e37 into aws:smithy-codegen Oct 17, 2019
@lock
Copy link

lock bot commented Oct 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants