Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(endpoint): e2e test fixes for endpoints 2.0 all services #4044

Merged
merged 1 commit into from
Oct 15, 2022
Merged

fix(endpoint): e2e test fixes for endpoints 2.0 all services #4044

merged 1 commit into from
Oct 15, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 15, 2022 •
edited
Loading

  • fixes e2e feature tests when in endpoints 2.0 mode
    • codegen a defaultSigningName for endpoint resolutions without an authScheme.signingName
    • correctly rename signingScope to signingName
    • fix RDS feature test

tested with

yarn copy-models (aws-models endpoints-2.0 branch)
yarn generate-clients
yarn build:all
yarn test:all
npx cucumber-js

This PR requires smithy-lang/smithy-typescript#615

@kuhe kuhe requested a review from a team as a code owner October 15, 2022 05:06
@kuhe kuhe mentioned this pull request Oct 15, 2022
Merged
@trivikr trivikr merged commit b53f5bd into aws:main Oct 15, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr