New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware-user-agent): ignore errors from inspecting credentials #6551

Merged

kuhe merged 1 commit into aws:main from kuhe:fix/features

Oct 8, 2024

Contributor

kuhe commented Oct 8, 2024 •

edited

Loading

From the PR comment:

// Sometimes config.credentials is a function but only throws
// as a way of informing users that something is missing.
// That error and any other errors are not relevant for feature-checking
// and are ignored.

kuhe requested a review from a team as a code owner

October 8, 2024 17:36


          fix(middleware-user-agent): ignore errors from inspecting credentials

8bc7d35

kuhe force-pushed the fix/features branch from 552af85 to 8bc7d35 Compare

October 8, 2024 17:38

siddsriv approved these changes

View reviewed changes

kuhe merged commit 4ddaa97 into aws:main

2 of 4 checks passed

kuhe deleted the fix/features branch

October 8, 2024 17:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet