fix(sqs): add queryCompatibility to json protocol #4405

kuhe · 2023-04-26T23:17:49Z

npm run test passes
n/a .d.ts file is updated
changelog is added, npm run add-change
n/a run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
run npm run integration if integration test is changed
n/a non-code related change (markdown/git settings etc)

Ran npx cucmber-js -t @sqs this time for both current and new model JSON.

lib/services/sqs.js

…rotocol

kuhe · 2023-04-28T22:21:51Z

npx cucumber-js -t @sqs is also passing with both JSON and Query protocols.

kuhe requested a review from a team as a code owner April 26, 2023 23:17

trivikr approved these changes Apr 26, 2023

View reviewed changes

kuhe commented Apr 26, 2023

View reviewed changes

lib/services/sqs.js Outdated Show resolved Hide resolved

kuhe force-pushed the fix/sqs branch 2 times, most recently from a25db48 to ccb85d0 Compare April 28, 2023 18:33

fix(sqs): set httpRequest.params in queryCompatibility mode in JSON p…

64c3e2b

…rotocol

kuhe force-pushed the fix/sqs branch from ccb85d0 to 64c3e2b Compare April 28, 2023 18:34

kuhe changed the title ~~fix(sqs): check for sqs queue url param in multiple places~~ fix(sqs): add queryCompatibility to json protocol Apr 28, 2023

trivikr approved these changes Apr 28, 2023

View reviewed changes

kuhe merged commit 543052d into aws:master Apr 28, 2023

kuhe deleted the fix/sqs branch April 28, 2023 22:24

Provide feedback