Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: internal region check before default #4419

Merged
merged 1 commit into from
May 12, 2023
Merged

chore: internal region check before default #4419

merged 1 commit into from
May 12, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 11, 2023 •
edited
Loading

Add {region}/internal-* region config check before the final */* default.

This has no effect on public clients, and will only be used internally.

Checklist
  • npm run test passes
  • n/a .d.ts file is updated
  • n/a changelog is added, npm run add-change
    • skipping this since this is internal feature
  • n/a run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • n/a run npm run integration if integration test is changed
  • n/a non-code related change (markdown/git settings etc)

@kuhe kuhe requested a review from a team as a code owner May 11, 2023 20:34
@kuhe kuhe merged commit 8cf76c9 into aws:master May 12, 2023
@kuhe kuhe deleted the feat/regions branch May 12, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr