Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM): endpoint in aws-iso partition #4422

Merged
merged 2 commits into from
May 17, 2023
Merged

fix(IAM): endpoint in aws-iso partition #4422

merged 2 commits into from
May 17, 2023

Conversation

pinak
Copy link
Contributor

@pinak pinak commented May 17, 2023

Fix endpoint for IAM for us-iso partition

IAM is partitional service, previously it was being treated as regional.

Checklist
  • npm run test passes -> tests don't even pass in master branch for me locally
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed

Fix endpoint for IAM for us-iso partition

IAM is partitional service, previously it was being treated as regional.
@pinak pinak requested a review from a team as a code owner May 17, 2023 08:35
@trivikr trivikr changed the title Update region_config_data.json fix(IAM): endpoint in aws-iso partition May 17, 2023
@trivikr
Copy link
Member

trivikr commented May 17, 2023

Verified that correct endpoint is logged for IAM

import AWS from "../aws-sdk-js/lib/aws.js";

const region = "us-iso-west-1";
const client = new AWS.IAM({ region });

// Logs iam.us-iso-east-1.c2s.ic.gov
console.log(`JS v2 endpoint for region '${region}':`, client.endpoint.host);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants