Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(codewhisperer): remove duplicate code #4033

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 13, 2023

Problem

testing

VSC

Auto trigger

vscode.auto.trigger.mov

Manual trigger

vscode.manual.trigger.mov

C9

Auto trigger

c9.auto.trigger.mov

Manual trigger

c9.manual.trigger.mov

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner November 13, 2023 09:16
@Will-ShaoHua Will-ShaoHua changed the title (refactor codewhisperer): reduce duplicate code (refactor codewhisperer): refactor 4, reduce duplicate code Nov 13, 2023
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Nov 21, 2023

will wait until post re:invent

@Will-ShaoHua Will-ShaoHua marked this pull request as draft November 21, 2023 10:38
@Will-ShaoHua Will-ShaoHua changed the title (refactor codewhisperer): refactor 4, reduce duplicate code (refactor codewhisperer): remove duplicate code Dec 5, 2023
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review December 5, 2023 19:56
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready?

@justinmk3 justinmk3 changed the title (refactor codewhisperer): remove duplicate code refactor(codewhisperer): remove duplicate code Dec 15, 2023
@Will-ShaoHua
Copy link
Contributor Author

is this ready?

@justinmk3 yea it's ready but should we wait until next year given it's not a P0 change, considering it's late Dec and we might have lower coverage for CX's issues in the following 1-2 wks?

@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Jan 4, 2024

@justinmk3 this one is ready to go thanks!

think the failing test is not relevant to the change here?

  1) Auth
    at MultiReporters.done (d:\a\aws-toolkit-vscode\aws-toolkit-vscode\node_modules\mocha-multi-reporters\lib\MultiReporters.js:124:16)
       Shared ini files
    at done (d:\a\aws-toolkit-vscode\aws-toolkit-vscode\node_modules\mocha\lib\mocha.js:1007:16)
         does not cache if the credentials file changes:
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Extension host test runner error Error: 1 tests failed.
      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
    at d:\a\aws-toolkit-vscode\aws-toolkit-vscode\src\test\testRunner.ts:90:28
+ actual - expected
    at MultiReporters.done (d:\a\aws-toolkit-vscode\aws-toolkit-vscode\node_modules\mocha-multi-reporters\lib\MultiReporters.js:124:16)

    at done (d:\a\aws-toolkit-vscode\aws-toolkit-vscode\node_modules\mocha\lib\mocha.js:1007:16)
  {
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
+   accessKeyId: 'x',
+   secretAccessKey: 'x',
-   accessKeyId: 'y',
-   secretAccessKey: 'y',
    sessionToken: undefined
  }
      + expected - actual

       {
      -  "accessKeyId": "x"
      -  "secretAccessKey": "x"
      +  "accessKeyId": "y"
      +  "secretAccessKey": "y"
         "sessionToken": [undefined]
       }
      

@justinmk3 justinmk3 merged commit 1e48a31 into aws:master Jan 4, 2024
12 of 15 checks passed
@Will-ShaoHua Will-ShaoHua deleted the cwspr-refactor-3 branch January 4, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants