You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct me if I'm wrong but won't packageCacheEnabledalways be false? Since JSII_RUNTIME_PACKAGE_CACHE is converted to uppercase and compared to a lowercase string literal.
Fix bug where cached enabled is always false.
fixes#3911
It took me a good 4 minutes to figure out that the PR title needs a to be prefixed with `fix:` including the colon 😄
---
By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].
[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.
Describe the bug
Correct me if I'm wrong but won't
packageCacheEnabled
always be false? SinceJSII_RUNTIME_PACKAGE_CACHE
is converted to uppercase and compared to a lowercase string literal.See code here
https://github.com/aws/jsii/blob/main/packages/@jsii/kernel/src/tar-cache/index.ts#L26-L27
Expected Behavior
export JSII_RUNTIME_PACKAGE_CACHE=enabled
should enable caching.Current Behavior
No caching.
after running cdk synth with that env variable
Reproduction Steps
pip install aws-cdk-lib
thencdk synth
for a very simple stack in python.Possible Solution
Change the line of code https://github.com/aws/jsii/blob/main/packages/@jsii/kernel/src/tar-cache/index.ts#L26-L27
Additional Information/Context
This is using python cdk version 2.59.0
SDK version used
jsii 1.72.0
Environment details (OS name and version, etc.)
Ubuntu 22.04.1 LTS
The text was updated successfully, but these errors were encountered: