Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): correctly de-serialize mappings as JSON #968

Merged
merged 5 commits into from
Nov 11, 2019
Merged

fix(kernel): correctly de-serialize mappings as JSON #968

merged 5 commits into from
Nov 11, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Nov 11, 2019 •
edited
Loading

When mapping data (e.g. a Python dict) was passed through a JSON value,
it would not be deserialized correctly and the $jsii.map markers would
remain in the JS-visible map.

Fixes the cause of aws/aws-cdk#4957

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller
fix(kernel): correctly de-serialize mappings as JSON
9481698 
When mapping data (e.g. a Python `dict`) was passed through a JSON value,
it would not be deserialized correctly and the `$jsii.map` markers would
remain in the JS-visible map.
@RomainMuller RomainMuller requested a review from a team as a code owner November 11, 2019 21:31
@RomainMuller RomainMuller self-assigned this Nov 11, 2019
@RomainMuller RomainMuller added bug This issue is a bug. effort/small Small work item – less than a day of effort module/kernel Issues affecting the `jsii-kernel` module labels Nov 11, 2019
eladb
eladb suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a python regresion test that verifies that this is fixed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller
Copy link
Contributor Author

@eladb done!!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller RomainMuller merged commit c731983 into master Nov 11, 2019
@RomainMuller RomainMuller deleted the rmuller/fix-nested-mapping-as-json branch November 11, 2019 22:51
RomainMuller added a commit that referenced this pull request Nov 11, 2019
@RomainMuller
fix(kernel): correctly de-serialize mappings as JSON (#968)
5d056f4 
When mapping data (e.g. a Python `dict`) was passed through a JSON value,
it would not be deserialized correctly and the `$jsii.map` markers would
remain in the JS-visible map.
mergify bot pushed a commit that referenced this pull request Nov 11, 2019
@RomainMuller @mergify
chore: retrofeed patch release into CHANGELOGs (#972)
42c5225 
* fix(kernel): correctly de-serialize mappings as JSON (#968)

When mapping data (e.g. a Python `dict`) was passed through a JSON value,
it would not be deserialized correctly and the `$jsii.map` markers would
remain in the JS-visible map.

* release: v0.20.3 (#971)

See CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@bmaizels bmaizels Awaiting requested review from bmaizels

Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort module/kernel Issues affecting the `jsii-kernel` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainMuller @aws-cdk-automation @eladb