Support for Spark 2.6.0

[sapessi]

There are some breaking changes in the embedded server interface.

[mkjois]

For reference, their changelog is here: http://sparkjava.com/news#spark-26-released

And the full commit history between 2.5.5 and 2.6.0: perwendel/spark@2.5.5...2.6.0

[dmcg]

Should you be looking for inspiration, this would be a really useful feature for us!

[sapessi]

@dmcg I'll try to make this available in 0.6 at the end of the month. I'll start testing next week.

[sapessi]

@dmcg @mkjois I've looked through the changes, they are minor but still breaking. I have two options:

1. Upgrade to spark 2.6.0 for all
2. Add a new module specifically for spark2.6.0

What would your preference be?

[mkjois]

My preference would be to upgrade to spark 2.6.0 for all, either in version 0.6 or 0.7.

I can understand option 2 but if you do go with it I think this module should continue to mature with Spark, while you can introduce a new module for staying with 2.5.3

[sapessi]

Thanks @mkjois - I will publish 0.6 as is since I have a bug fix for the servlet specs that should be included in all releases. From 0.7-SNAPSHOT I will upgrade to spark 2.6.0 for all.

[sapessi]

Hey @mkjois, I just pushed a commit to the spark-upgrade branch that supports 2.6.0. If you get a chance, can you give it a try?

[sapessi]

Merged upgraded changes into master. Closing this issue.

[mkjois]

@sapessi Sorry didn't get to test, I'm pretty swamped at work this week.

Thanks for the upgrade though! Might want to update the readme with a note about these versions as well

[lynx-r]

Could you provide an example?

[lynx-r]

Nevermind. I got it working the problem which I got was in included compile 'com.sparkjava:spark-debug-tools:0.5'

[sapessi]

hey @helloalleo, what problem were you running into? Was there a specific exception?

[lynx-r]

I got this error when included compile 'com.sparkjava:spark-debug-tools:0.5'

java.lang.ClassCastException: spark.SparkInstance cannot be cast to spark.Service
at com.amazonaws.serverless.proxy.spark.SparkLambdaContainerHandler.<init>(SparkLambdaContainerHandler.java:120)
at com.amazonaws.serverless.proxy.spark.SparkLambdaContainerHandler.getAwsProxyHandler(SparkLambdaContainerHandler.java:92)
at com.workingbit.article.LambdaHandler.handleRequest(LambdaHandler.java:19)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)