Add deprecated option to config field resolvers #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaiahvita
commented
Jun 7, 2023
| @@ -1,10 +1,10 @@ | |||
| package middleware | |||
There was a problem hiding this comment.
for some reason, in previous ep20 commits, i modified this middleware/metadata.go file which shouldnt have been modified at all. these modifications resulted in breaking changes in middleware signatures. so in this commit im reverting it to its original state (prior to any ep20 commits)
lucix-aws
approved these changes
Jun 7, 2023
aajtodd
approved these changes
Jun 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility may be necessary for consumers if they want to deprecated a With helper function that corresponds to a config field