Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints2.0 middleware and param binding generation. #430

Merged
merged 9 commits into from
Jun 23, 2023

Conversation

isaiahvita
Copy link
Contributor

All endpoints2.0 middleware and parameter binding generation lives here, while hooks were added for builtin generation on consumer SDKs

@isaiahvita isaiahvita requested review from a team as code owners June 22, 2023 17:48
@isaiahvita isaiahvita changed the base branch from main to ep20 June 22, 2023 17:53
*
* @param writer Settings used to generate.
*/
default void renderEndpointBuiltInField(GoWriter writer) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: It might be better to collapse these into one method that returns a type responsible for these different things.

e.g.

default void endpointBuiltinHandler(): EndpointBuiltInHandler


interface EndpointBuiltInHandler {
    default void renderEndpointBuiltInField(GoWriter writer) { }

    default void renderEndpointBuiltInInvocation(GoWriter writer) {}

    default void renderEndpointBuiltInInitialization(GoWriter writer, Parameters parameters) { }
}

Grouping these things together reduces the API surface of GoIntegration, it also helps in finding all the various methods that may need overridden for related functionality.

@isaiahvita isaiahvita merged commit 49e1236 into aws:ep20 Jun 23, 2023
@isaiahvita isaiahvita deleted the ep20-middleware branch June 23, 2023 18:30
@syall syall mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants