Add accountID into endpoint2.0 param binding #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
requested changes
Feb 5, 2024
| @@ -42,7 +43,7 @@ public GoWriter.Writable generate() { | |||
| loadResolvers(); | |||
|
|
|||
| return goTemplate(""" | |||
| func $name:L(operation string, input interface{}, options Options) $params:P { | |||
| func $name:L(operation string, input interface{}, options Options, ctx $context:T) $params:P { | |||
There was a problem hiding this comment.
Context, as a rule, goes first in an API's argument list.
lucix-aws
approved these changes
Feb 7, 2024
wty-Bryant
added a commit
that referenced
this pull request
Jun 14, 2024
* Add accountID endpoint builtin and aid mode config * Modify endpoint builtin codegen --------- Co-authored-by: Tianyi Wang <wty@amazon.com>
wty-Bryant
added a commit
that referenced
this pull request
Jun 17, 2024
* Add accountID into endpoint2.0 param binding (#496) * Add accountID endpoint builtin and aid mode config * Modify endpoint builtin codegen --------- Co-authored-by: Tianyi Wang <wty@amazon.com> * add changelog * fix changelog --------- Co-authored-by: Tianyi Wang <wty@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the ep2.0 resolution, the accountID param is retrieved from ctx's credentials, thus in this PR, the ctx is added as a new param into endpoint binding func codegen.