Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement both the Add and Delete operations as no-ops #847

Merged
merged 11 commits into from
Aug 7, 2024

Commits on Jul 25, 2023

  1. Implement both the Add and Delete operations as nops

    These two operations are called when docker tries to store and delete
    credentials (docker login and docker logout) respectively. This change
    makes it so that both of these operations are implemented as nops
    instead of returning a "not implemented" error.
    
    The goal here is to ensure compatibilities with applications and tools
    that call docker login or docker logout for the user as part of their
    normal operations.
    dotboris authored and sparr committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    39e8b95 View commit details
    Browse the repository at this point in the history
  2. Fix typo in add's nop log

    dotboris authored and sparr committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6eb364e View commit details
    Browse the repository at this point in the history
  3. Use WithField when logging warning

    dotboris authored and sparr committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2540a1c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c6ec84 View commit details
    Browse the repository at this point in the history
  5. Apply suggestions from code review

    Co-authored-by: Gavin Inglis <43075615+ginglis13@users.noreply.github.com>
    dotboris and ginglis13 authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c2915f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    abd9b85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    064c82d View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    4f42b4e View commit details
    Browse the repository at this point in the history
  2. fix: guide users to setting AWS_ECR_IGNORE_CREDS_STORAGE var for ecr-…

    …login
    
    With the new capability to opt-out of saving credentials, we can guide
    users to not to save ecr credentials by setting the
    AWS_ECR_IGNORE_CREDS_STORAGE environment variable when encountering the
    `notImplemented` error.
    
    Ref:
    https://docs.aws.amazon.com/cli/latest/reference/ecr/get-login-password.html
    therealvio committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    56b9e70 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Configuration menu
    Copy the full SHA
    4daacfd View commit details
    Browse the repository at this point in the history
  2. test: use the current test scope, not parent

    This change fixes an incorrect use of the test's scope. The parent
    was used for assertions and setting the env. This now should be using
    the correct instance of the `*testing.T` for the test.
    therealvio committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d551297 View commit details
    Browse the repository at this point in the history