-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement both the Add and Delete operations as no-ops #847
Merged
Commits on Jul 25, 2023
-
Implement both the Add and Delete operations as nops
These two operations are called when docker tries to store and delete credentials (docker login and docker logout) respectively. This change makes it so that both of these operations are implemented as nops instead of returning a "not implemented" error. The goal here is to ensure compatibilities with applications and tools that call docker login or docker logout for the user as part of their normal operations.
Configuration menu - View commit details
-
Copy full SHA for 39e8b95 - Browse repository at this point
Copy the full SHA 39e8b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb364e - Browse repository at this point
Copy the full SHA 6eb364eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2540a1c - Browse repository at this point
Copy the full SHA 2540a1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c6ec84 - Browse repository at this point
Copy the full SHA 2c6ec84View commit details -
Apply suggestions from code review
Co-authored-by: Gavin Inglis <43075615+ginglis13@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c2915f7 - Browse repository at this point
Copy the full SHA c2915f7View commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for abd9b85 - Browse repository at this point
Copy the full SHA abd9b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 064c82d - Browse repository at this point
Copy the full SHA 064c82dView commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f42b4e - Browse repository at this point
Copy the full SHA 4f42b4eView commit details -
fix: guide users to setting AWS_ECR_IGNORE_CREDS_STORAGE var for ecr-…
…login With the new capability to opt-out of saving credentials, we can guide users to not to save ecr credentials by setting the AWS_ECR_IGNORE_CREDS_STORAGE environment variable when encountering the `notImplemented` error. Ref: https://docs.aws.amazon.com/cli/latest/reference/ecr/get-login-password.html
Configuration menu - View commit details
-
Copy full SHA for 56b9e70 - Browse repository at this point
Copy the full SHA 56b9e70View commit details
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4daacfd - Browse repository at this point
Copy the full SHA 4daacfdView commit details -
test: use the current test scope, not parent
This change fixes an incorrect use of the test's scope. The parent was used for assertions and setting the env. This now should be using the correct instance of the `*testing.T` for the test.
Configuration menu - View commit details
-
Copy full SHA for d551297 - Browse repository at this point
Copy the full SHA d551297View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.