New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTCP component as submodule after re-factoring #2027

Merged

moninom1 merged 18 commits into develop from rtcpWrapper

Aug 8, 2024

Contributor

moninom1 commented Jul 11, 2024

Issue #, if available:

What was changed?
Add RTCP component as external project, and update RTCP code to call APIs of component.

Why was it changed?
To apply RTCP re-factoring component into dev branch. RTP component is separated out as independent library.

How was it changed?
Add RTCP component as external project, import it via ExternalProject_Add, and update RTCP code to call APIs of component.

What testing was done for the changes?

Verified master demo on Ubuntu
Verified serialization & deserialization with webrtc_client_test and pass all test cases.
Verified TWCC with unit test framework in RTCP component

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

moninom1 commented

View reviewed changes

tst/RtcpFunctionalityTest.cpp Show resolved Hide resolved

moninom1 commented

View reviewed changes

tst/RtcpFunctionalityTest.cpp Show resolved Hide resolved

unicornss reviewed

View reviewed changes

src/source/PeerConnection/Rtcp.c Show resolved Hide resolved

unicornss reviewed

View reviewed changes

src/source/Rtcp/RtcpPacket.c Outdated Show resolved Hide resolved

unicornss reviewed

View reviewed changes

src/source/PeerConnection/Rtcp.c Outdated Show resolved Hide resolved

unicornss reviewed

View reviewed changes

CMake/Utilities.cmake Outdated Show resolved Hide resolved

unicornss reviewed

View reviewed changes

src/source/Rtcp/RtcpUtils.c Outdated Show resolved Hide resolved

unicornss reviewed

View reviewed changes

Contributor

unicornss left a comment

consistency, initialization and clarity can be improved.

moninom1 force-pushed the rtcpWrapper branch from 96c292c to 6d57653 Compare

July 22, 2024 08:50

moninom1 added 13 commits

July 22, 2024 10:01


          Initial Changes

14d701c


          Update deserialization

e14d801


          Update serialization

fcf8f7d


          Add SLI, PLI, FIR parsing

acae870


          parse sender report

e717031


          Parse receiver report

33c7f20


          Parse remb packet

1dfbbab


          Update according to new RTCP code

d007296


          Update packet type functions

a0eb7f0


          Address comments

57b0004


          Add convertRtcpErrorCodeTest test case

c25d893


          Update according to rtcp library

f398c44


          Remove unused variable

cc1a5e3

moninom1 force-pushed the rtcpWrapper branch from 6d57653 to cc1a5e3 Compare

July 22, 2024 10:01

moninom1 added 5 commits

July 22, 2024 11:14


          Update function def

d788b4b


          Update formatting

c141ab2


          Add newline at end of the file

38c90a3


          Merge branch 'develop' into rtcpWrapper

21dd82b


          Point to the main branch commit

3711e4d

hassanctech self-requested a review

August 6, 2024 12:59

hassanctech approved these changes

View reviewed changes

Contributor

hassanctech left a comment

LGTM

aggarg approved these changes

View reviewed changes

moninom1 merged commit ace791c into develop

31 checks passed

moninom1 deleted the rtcpWrapper branch

August 8, 2024 07:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet