Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Add tests for CloudFront signed urls to testing pipeline #212

Merged
merged 29 commits into from
Apr 14, 2021
Merged

Add tests for CloudFront signed urls to testing pipeline #212

merged 29 commits into from
Apr 14, 2021

Conversation

nathanagez
Copy link
Collaborator

Issue #197

Description of changes:

  • Add resources deletion if stack deployment fails
  • Test CloudFront signed urls

Close #197

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nathanagez nathanagez self-assigned this Feb 24, 2021
@wizage
Copy link
Contributor

wizage commented Feb 24, 2021

LGT2M

We need to figure out how we can run this as right now Github doesn't support pull request accessing secrets. My thoughts are to add a release pipeline. So to release you can run:

npm release <versionnumber> and it goes and updates the version numbers, publishes to npm with Beta tag and then creates a new git branch and pushes it to a beta branch. Then inside of Github you make a pull request off beta branch to trigger the Jest tests before final release to NPM

@nathanagez
Copy link
Collaborator Author

LGT2M

We need to figure out how we can run this as right now Github doesn't support pull request accessing secrets. My thoughts are to add a release pipeline. So to release you can run:

npm release <versionnumber> and it goes and updates the version numbers, publishes to npm with Beta tag and then creates a new git branch and pushes it to a beta branch. Then inside of Github you make a pull request off beta branch to trigger the Jest tests before final release to NPM

@wizage what do you mean by Github doesn't support pull request accessing secrets ? It works on the forked repository

I added in Settings -> Secrets:

  • TEST_AWS_ACCESS_KEY_ID
  • TEST_AWS_SECRET_ACCESS_KEY

Is it different here ?

@wizage
Copy link
Contributor

wizage commented Feb 25, 2021

https://stackoverflow.com/questions/62142092/is-it-okay-to-use-github-secrets-with-a-public-repo

Per this article:

Public repository pull_request events triggered by forks do not have access to secrets, except for the default GITHUB_TOKEN. Additionally, The GITHUB_TOKEN has read-only access when an event is triggered by a forked repository. These are intentional restrictions enforced by GitHub Actions to prevent an attacker creating a pull request containing a workflow that captures secrets, or uses secrets to perform operations.

@nathanagez nathanagez changed the title Test CloudFront signed urls to testing pipeline Add tests for CloudFront signed urls to testing pipeline Mar 4, 2021
@wizage wizage merged commit 0b14dc9 into awslabs:master Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test CloudFront signed URL with the VoD workflow
3 participants