Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add user_first_touch_timestamp user attribute in _first_open event #34

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add user_first_touch_timestamp in _first_open event

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Dec 5, 2023
@zhu-xiaowei zhu-xiaowei changed the title fix: add user_first_touch_timestamp in _first_open event fix: add user_first_touch_timestamp user attribute in _first_open event Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef4e5ed) 100.00% compared to head (3275d1d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          995       995           
  Branches       183       183           
=========================================
  Hits           995       995           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 9ac62f6 into main Dec 5, 2023
4 checks passed
@zxkane zxkane deleted the fix-user-attribute branch December 5, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants