Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set IFS when calling provider commands #30

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Explicitly set IFS when calling provider commands #30

merged 1 commit into from
Jun 27, 2016

Conversation

aramprice
Copy link
Contributor

  • add test for error git secrets --aws-provider: command not found
    which occurs when space-containing provider command is executed

Fixes #29

@aramprice
Explicitly set IFS when calling provider commands
8619077 
- add test for error `git secrets --aws-provider: command not found`
  which occurs when space-containing `provider` command is executed

Fixes #29
@aramprice aramprice mentioned this pull request Jun 21, 2016
Closed
@aramprice
Copy link
Contributor Author

A couple of notes:

  • I'm not certain that this addresses all IFS issues which may have been introduced in 9fa6d45.
  • There may be a better (positive) test case which could be written for the provider code.

@mtdowling mtdowling merged commit 8619077 into awslabs:master Jun 27, 2016
@mtdowling
Copy link
Contributor

Looks good to me. Thanks!

@aramprice
Copy link
Contributor Author

thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aramprice @mtdowling