Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped redoc version to 2.0.0-rc.23 #543

Conversation

rafalolszewski94
Copy link
Contributor

Major fix for me was

fix broken sticky sidebar in Chrome 80

Redoc official changelog

Below changes since rc.14


2.0.0-rc.23 (2020-02-09)

Bug Fixes

  • fix broken sticky sidebar in Chrome 80 (1a2a7dd), closes #1167

2.0.0-rc.22 (2020-01-15)

Bug Fixes

  • do not process oneOf if inherited from parent with discriminator (5248415)

Features

2.0.0-rc.21 (2020-01-10)

Bug Fixes

  • empty servers behaviour per OAS spec (ed1db0c), closes #1151
  • fix duplicated content in tags when using md headings (a260c84), closes #1150 #1152
  • use mobile menu background color value from theme (#1144) (41a9b3c)

2.0.0-rc.20 (2019-12-13)

Bug Fixes

2.0.0-rc.19 (2019-12-13)

Bug Fixes

Features

  • display multipleOf constrains (#1065) (3e90133)
  • enable menuToggle by default (5d81abe)
  • new option hideSchemaTitles (11cc4c4)
  • new option payloadSampleIdx (eaaa99d)
  • cli: Fallback on the spec's title before falling back on… (#1073) (e01eea4)

2.0.0-rc.18 (2019-10-16)

Bug Fixes

  • add oneOf buttons vertical space when wrapped to new line (cd9fd61)
  • improve mime-type dropdown font (ce885f8)

2.0.0-rc.17 (2019-10-16)

Bug Fixes

Features

  • added support for file paths as --options cli argument (#1049) (4adb927)

2.0.0-rc.16 (2019-09-30)

Bug Fixes

  • fix scrollYOffset when SSR (d09c1c1)

2.0.0-rc.15 (2019-09-30)

Bug Fixes

  • auth section appears twice (5aa7784), closes #818
  • clicking on group title breaks first tag (4649683), closes #1034
  • do not crash on empty scopes (e787d9e), closes #1044
  • false-positive recursive detection with allOf at the same level (faa74d6)
  • fix scrollYOffset when SSR (21258a5)
  • left menu item before group is not highlighted (67e2a8f), closes #1033
  • remove excessive whitespace between md sections on small screens (e318fb3), closes #874
  • use url-template dependency (#1008) (32a464a), closes #1007

Features

  • cli: added support for JSON string value for --options CLI argument (#1047) (2a28130), closes #797
  • cli: add disableGoogleFont parameter to cli (#1045) (aceb343)
  • new option expandDefaultServerVariables (#1014) (0360dce)

@jmiazga
Copy link

jmiazga commented Feb 13, 2020

+1 on this

@rafalolszewski94
Copy link
Contributor Author

CI check is false.
Errors mentioned in there are Python related and are not connected to anything done in this PR.

@ghost
Copy link

ghost commented Mar 5, 2020

@rafalolszewski94 I Installed the requirement from your Branch at solved the issue on my end.
Thank you 🙏

@hanqyu
Copy link

hanqyu commented Mar 14, 2020

I found that the problem fix broken sticky sidebar in Chrome 80 can be solved if you enlarge your window in chrome. Just pressing command and + button saved me.

And I don't know for some reason, but resizing to normal couldn't reoccur the problem.

I hope this would be helpful to others.
I'm using macbook 13-inch with 1680 x 1050 and chrome 80.

@Arti3DPlayer
Copy link

+1 to merge because of fix broken sticky sidebar in Chrome 80

@jmiazga
Copy link

jmiazga commented Apr 8, 2020

I forked this repo to update redoc and swagger: https://github.com/vndly-oss/drf-yasg

@cupcoder
Copy link

cupcoder commented Apr 10, 2020

+1 Really need to fix this asap. The current release is basically broken for Chrome which is 80% of our user base.

@mic159
Copy link

mic159 commented May 3, 2020

It's a shame this project is basically dead.
To get around this, I added my own template & redoc min-js.

from drf_yasg.views import UI_RENDERERS, ReDocRenderer, get_schema_view


class NewRenderer(ReDocRenderer):
    template = "thisapp/new_docs.html"


UI_RENDERERS["redoc-new"] = (NewRenderer,)
...
url(r"^$", api_schema_view.with_ui("redoc-new"),),

The template is basically the same, but with the script tag replaced with a static tag pointing to my updated version of the JS.

@hnykda hnykda mentioned this pull request May 7, 2020
@taraspos
Copy link

taraspos commented Sep 7, 2020

There are a couple of related issues (like #548) and PRs (like #625) already open , but no-one is merging them :(

If someone is interested in in my workaround with Dockerfile:

FROM redocly/redoc:v2.0.0-rc.40 as redoc
FROM swaggerapi/swagger-ui:v3.32.5 as swagger-ui
FROM python:3.8-alpine3.12 as base

# building all the requirements in temp container
FROM base as builder

WORKDIR /install
ENV PIP_PREFIX /install

RUN pip install -r /requirements.txt

# workaround to update ReDoc UI, because project drf-yasg seems to be close to dead
# but no nice substitution for it yet, see issue: https://github.com/axnsan12/drf-yasg/pull/543
COPY --from=redoc      /usr/share/nginx/html/redoc.standalone.js    lib/python3.8/site-packages/drf_yasg/static/drf-yasg/redoc/redoc.min.js
# same with swagger ui
COPY --from=swagger-ui /usr/share/nginx/html/swagger-ui*            lib/python3.8/site-packages/drf_yasg/static/drf-yasg/swagger-ui-dist/
COPY --from=swagger-ui /usr/share/nginx/html/oauth2-redirect.html   lib/python3.8/site-packages/drf_yasg/static/drf-yasg/swagger-ui-dist/
COPY --from=swagger-ui /usr/share/nginx/html/favicon*               lib/python3.8/site-packages/drf_yasg/static/drf-yasg/swagger-ui-dist/

@johnthagen
Copy link
Collaborator

@axnsan12 Do you think you will be able to get these important PR's merged? Do you need new maintainers #590? Or should this project be forked so it can continue?

@johnthagen
Copy link
Collaborator

This has been implemented and fixed in the active fork, drf-yasg2.

See: JoelLefkowitz#69

@axnsan12
Copy link
Owner

Fixed in master now, updated to rc40, sorry for disappearing.

@axnsan12 axnsan12 closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment