re-enable DPO for tests in modal ci #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @winglian can you retry merging this? I just ran it myself and it passed: $ git co dpo-modal-ci
branch 'dpo-modal-ci' set up to track 'origin/dpo-modal-ci'.
Switched to a new branch 'dpo-modal-ci'
$ export BASE_TAG=main-base-py3.10-cu121-2.1.2
$ export PYTORCH_VERSION=2.1.2
$ export CUDA=121
$ export N_GPUS=1
$ MODAL_PROFILE=modal_labs modal run --detach cicd.testsTest summary: |
winglian
force-pushed
the
dpo-modal-ci
branch
2 times, most recently
from
c8079f9
to
c475885
Compare
|
Thanks, let me know in Slack if there's any other issues 🙏 |
TypeError: non-default argument follows default argument error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)