Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_causal fix for evals? #451

Merged
merged 2 commits into from
Aug 21, 2023
Merged

is_causal fix for evals? #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf49a4
is_causal fix for evals?
winglian Aug 21, 2023
a213d99
fix eval regression caused in 13f7efaf74fcd3c4514277ccb71914c589873f6a
tmm1 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/axolotl/monkeypatch/llama_attn_hijack_flash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def flashattn_forward(
else:
# turn off FA causal mask after first inference autoregressive iteration
# only on first autoregressive step q,k,v have same seqlen
is_causal = past_key_value is not None
is_causal = key_states.shape == query_states.shape

if cu_seqlens is not None and max_seqlen is not None:
# special handling using sample packing
Expand Down