Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DB/C_T-SAI-GOBJ): NPC: Lady Falther'ess and Scourge Invasion Event #5787

Closed
wants to merge 4 commits into from
Closed

fix(DB/C_T-SAI-GOBJ): NPC: Lady Falther'ess and Scourge Invasion Event #5787

wants to merge 4 commits into from

Conversation

The-GhostRider
Copy link
Contributor

@The-GhostRider The-GhostRider commented May 11, 2021 •
edited

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

Lady.Falther.ess.mp4

How to Test the Changes:

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB label May 11, 2021
@Maurowin
Copy link
Contributor

As stated here, I am not in favor of having a non-blizzlike patch.

@Kitzunu
Copy link
Member

Kitzunu commented May 11, 2021 •
edited

All good me and shin talked about it.

I believe there is an existing game event for scourge invation in game_event. Could you link the NPC to this event @Stifler82 this way we can get it for the correct event.

If the gob is supposed to be spawned, I suggest you add conditions for SAI only to execute when event is active. Otherwise add it to event spawn too.

Good job with the initial work 👍

@Maurowin
Copy link
Contributor

All good me and shin talked about it.

I believe there is an existing game event for scourge invation in game_event. Could you link the NPC to this event @Stifler82 this way we can get it for the correct event.

If the gob is supposed to be spawned, I suggest you add conditions for SAI only to execute when event is active. Otherwise add it to event spawn too.

Good job with the initial work 👍

If it has to be part of an event, that's ok. If the intention of the developer is to spawn it even if the event is not active, it is problematic.

@The-GhostRider
Copy link
Contributor Author

All good me and shin talked about it.

I believe there is an existing game event for scourge invation in game_event. Could you link the NPC to this event @Stifler82 this way we can get it for the correct event.

If the gob is supposed to be spawned, I suggest you add conditions for SAI only to execute when event is active. Otherwise add it to event spawn too.

Good job with the initial work 👍

Hey @Kitzunu, I just finished Fixing "Event 17" Scourge Invasion

Now I'm tired, but tomorrow I'll make a video and show you the event with all the IDs so you can tell me what needs to be changed if necessary.

@Maurowin
Copy link
Contributor

All good me and shin talked about it.
I believe there is an existing game event for scourge invation in game_event. Could you link the NPC to this event @Stifler82 this way we can get it for the correct event.
If the gob is supposed to be spawned, I suggest you add conditions for SAI only to execute when event is active. Otherwise add it to event spawn too.
Good job with the initial work 👍

Hey @Kitzunu, I just finished Fixing "Event 17" Scourge Invasion

Now I'm tired, but tomorrow I'll make a video and show you the event with all the IDs so you can tell me what needs to be changed if necessary.

I can't wait to test this!

@azerothcore azerothcore deleted a comment from The-GhostRider May 11, 2021
@azerothcore azerothcore deleted a comment from Maurowin May 11, 2021
@The-GhostRider

This comment has been minimized.

Sign in to view
@Maurowin

This comment has been minimized.

Sign in to view
@The-GhostRider

This comment has been minimized.

Sign in to view
@Maurowin

This comment has been minimized.

Sign in to view
@The-GhostRider

This comment has been minimized.

Sign in to view
@Branel

This comment has been minimized.

Sign in to view
@The-GhostRider The-GhostRider changed the title fix(DB/C_T-SAI-GOBJ): NPC: Lady Falther'ess fix(DB/C_T-SAI-GOBJ): NPC: Lady Falther'ess and Scourge Invasion Event May 24, 2021
@ghost ghost removed the DB label Oct 5, 2021
@Nefertumm
Copy link
Member

Status on this?

@Nefertumm Nefertumm added DB related to the SQL database Instance - Dungeon - Vanilla labels Oct 6, 2021
@Nyeriah Nyeriah added the PR Abandoned Original author stopped working on this PR. Feel free to take over. label Oct 26, 2021
@heyitsbench heyitsbench mentioned this pull request Dec 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DB related to the SQL database Instance - Dungeon - Vanilla PR Abandoned Original author stopped working on this PR. Feel free to take over.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Razorfen Downs] - Boss implementation: Lady Falther'ess
7 participants
@The-GhostRider @Maurowin @Kitzunu @Branel @Nefertumm @FrancescoBorzi @Nyeriah