Core/Misc: rename namespaces and macros to acore #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For pass build need ElunaLuaEngine/Eluna#299 |
|
Instead of just removing the module script from Travis I added comments in order to provide information about what's going on here. |
ghost
mentioned this pull request
1 task
Thank you, that was very helpful! |
lower case cleanup rename trinity_string
Winfidonarleyan
force-pushed
the
rename
branch
from
df5602b
to
828de48
Compare
ghost
mentioned this pull request
1 task
Winfidonarleyan
approved these changes
Nov 28, 2019
Winfidonarleyan
approved these changes
Nov 28, 2019
|
@Viste @Winfidonarleyan has anyone tested this? can it be merged? |
|
Tested:
Everything looks normal. Ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES PROPOSED:
HOW TO TEST THE CHANGES: build run fun in game?
Target branch(es):