fix(Core/Config): add support '#' for password and etc

[Winfidonarleyan]

Changes Proposed:

Issues Addressed:

• Closes Cannot connect to Database if password uses special character #4781

Tests Performed:

How to Test the Changes:

Target Branch(es):

• Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

[Winfidonarleyan]

@D3thw0lf try this

[D3thw0lf]

Sadly it's still not working as before. Just use one # in your password for your database e.g. thisismy#secret and no other # in the same line. If I add another comment # behind the password stuff it starts.

Example (not working, but working before the linked pull in my issue):
WorldDatabaseInfo = "localhost;3306;root;supersecret#password;world"

Example (now working since this pr):
WorldDatabaseInfo = "localhost;3306;root;supersecret#password;world" #

I hope you understand what I'm trying to tell you. ^^' sorry for my possible bad english sometimes.

[Mitradis]

remove all this block:
size_t found = line.find_last_of('#');
if (found != std::string::npos)
line = line.substr(0, found);
why this needed? who will use # in end of string for commenting??? just stuped.

[Winfidonarleyan]

remove all this block:
size_t found = line.find_last_of('#');
if (found != std::string::npos)
line = line.substr(0, found);
why this needed? who will use # in end of string for commenting??? just stuped.

#4781