Core/Scripts: Meathook and Salramm should patrol once they spawn. #942

FALL1N1 · 2018-06-24T00:35:04Z

[CULLING OF STRATHOLME 5MAN DUNGEON] Currently both bosses just spawn and doesn't move at all. Instead they should spawn and start patrolling around.

Note: Waypoints are not blizzlike, i just ran around and generated some random. ss: http://prntscr.com/jyl1lo

FALL1N1 · 2018-06-25T21:27:19Z

ignore this pr for now, will be fixed by friday unless someone else wants to do it

BarbzYHOOL · 2018-07-04T22:32:27Z

Waypoints are not blizzlike, i just ran around and generated some random

better than none!

Knindzagxg · 2018-11-17T20:55:08Z

If i remember, only Meathook roam whole distance u draw, second one only like 30-40 yards of hes spawn location. Will check on retail once i can.

FrancescoBorzi · 2018-12-22T16:07:27Z

Looking for @FALL1N1 or someone else to complete the work that has been previously started here.

Si1ker · 2020-03-04T05:04:53Z

@FrancescoBorzi Hello, this PR got my attention for a bit.

I included the changes proposed here but it didn't compile completely for me.

Besides, I noticed that there is no source about the Meathook and Salramm patrol behavior in this PR when it was created, I spent almost an hour trying to find videos on YT, comments on wowhead and wikis about this movement but I only got info about this patrolling behavior on cataclysm and the other expansions ahead but not for woltk, is there any source that can confirm this patrol behavior for those 2 bosses in woltk? Thanks.

FrancescoBorzi · 2020-03-04T08:45:48Z

@Si1ker not that I'm aware of :(

BarbzYHOOL · 2020-03-04T20:56:39Z

Post your errors Silker

FALL1N1 · 2020-03-05T18:28:28Z

Paste me the build log and I'll fix it, sadly I cannot build it as I cannot compile on my laptop because it will melt down, got no access to my workstation.

BarbzYHOOL · 2020-03-05T18:46:55Z

@Si1ker

Si1ker · 2020-03-06T04:46:41Z

@BarbzYHOOL Thanks for the tag 👍
@FALL1N1 After including the changes proposed, that's what I've got:

Note: For this PR, if you cannot compile, send me the changes, I'll include them and compile in behalf of you (ignore the rev-hash message)

1>------ Build started: Project: revision.h, Configuration: Release x64 ------
2>------ Skipped Build: Project: clean_cotire, Configuration: Release x64 ------
2>Project not selected to build for this solution configuration
1>--
1> Could not find a proper repository signature (hash) - you may need to pull tags with git fetch -t
1> Continuing anyway - note that the versionstring will be set to "unknown 1970-01-01 00:00:00 (Archived)"
3>------ Build started: Project: scripts, Configuration: Release x64 ------
3>boss_meathook.cpp
3>boss_salramm.cpp
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\scripts\Kalimdor\CavernsOfTime\CullingOfStratholme\boss_salramm.cpp(51): error C2259: 'boss_salramm::boss_salrammAI': cannot instantiate abstract class
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\scripts\Kalimdor\CavernsOfTime\CullingOfStratholme\boss_salramm.cpp(51): note: due to following members:
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\scripts\Kalimdor\CavernsOfTime\CullingOfStratholme\boss_salramm.cpp(51): note: 'void npc_escortAI::WaypointReached(uint32)': is abstract
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\scripts\Kalimdor\CavernsOfTime\CullingOfStratholme\boss_meathook.cpp(41): error C2259: 'boss_meathook::boss_meathookAI': cannot instantiate abstract class
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\game\AI\ScriptedAI\ScriptedEscortAI.h(77): note: see declaration of 'npc_escortAI::WaypointReached'
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\scripts\Kalimdor\CavernsOfTime\CullingOfStratholme\boss_meathook.cpp(41): note: due to following members:
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\scripts\Kalimdor\CavernsOfTime\CullingOfStratholme\boss_meathook.cpp(41): note: 'void npc_escortAI::WaypointReached(uint32)': is abstract
3>C:\Users\Silker\Desktop\server\azerothcore-wotlk-master\src\server\game\AI\ScriptedAI\ScriptedEscortAI.h(77): note: see declaration of 'npc_escortAI::WaypointReached'
3>Done building project "scripts.vcxproj" -- FAILED.
4>------ Skipped Build: Project: INSTALL, Configuration: Release x64 ------
4>Project not selected to build for this solution configuration
========== Build: 1 succeeded, 1 failed, 20 up-to-date, 2 skipped ==========

FALL1N1 · 2020-03-06T10:58:36Z

thanks, now all we need is a volunteer to test if it works

BarbzYHOOL · 2020-03-06T16:47:28Z

@FALL1N1 thank you!
@Si1ker we count on you (more and more :P)!

FALL1N1 · 2020-03-06T17:00:41Z

build on VS19 works just fine, travis is being a bitch.. so in short:

it works as intended and builds fine
it does not pass the travis-ci build due to the code being ugly/non-standart

if anyone is interested in fixing the travis - feel free to do so

Si1ker · 2020-03-09T05:17:29Z

@BarbzYHOOL Ok n.n
@FrancescoBorzi I've checked in Warmane, both are walking the same path provided in this PR, ty
@FALL1N1 Now it is building, it compiled with no problem and both bosses follow the WPs in-game, but there's a problem with the map.

When meathook, goes from wp#1 to wp#2, in this transition he goes under map and then emerges in wp#3 to follow towards the wp#4 flying above the map.

Then all you have is a Meathook flying..

In the other hand, we have Salram under map all his way in the same point Meathook had his problem, in the transition from wp#1 to wp#2

-- I tried adding multiple WPs to have a "better" path but I think it is more related with the vmap.. : /

The problem always starts here: in the smoke at the right side, he goes under map, in the smoke at the left side he emerges and follows the other WPs (meathook flying and Salram under map), at some point for some reason they "update" his movement and goes as expected but again when they reach the [right smoke] the same problem happens.

I'll be trying with around 20 WPs to have a more efficient and complex way, after that Illl be out of ideas haha 🐱 , but again, I think is vmap/map related.

Note= I have my maps updated (as my core/hash)

It is like the problem with Kel'Thuzaad adds in Phase 1 of Naxxramas, some mobs generated in these gates go under the map:
Green = Good = Above map
Red = Bad = Under map

FALL1N1 · 2020-03-09T12:52:03Z

The issue is indeed from the vmaps/mmaps, we have discussed it in a previous issue at stranglethorn vale somewhere near a cliff where they went straight through the cliff instead of finding a path to the top.

BarbzYHOOL · 2020-03-09T17:42:00Z

damned mmaps like here #2688

ok so what must we do with the PR now?

FrancescoBorzi · 2020-03-09T21:51:22Z

General tip for testers: when finding issues while testing, please specify whether they are regressions (new issues that weren't on master) or not. In the second case, the PR could still be merged.

BarbzYHOOL · 2020-03-09T22:01:44Z

if the map issue is fixed in the future, what about this PR then?

PkllonG · 2020-06-28T23:04:48Z

src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/boss_salramm.cpp

@@ -103,7 +118,7 @@ class boss_salramm : public CreatureScript
                    }
        }



+void WaypointReached(uint32 waypointId) { }

PkllonG · 2020-06-28T23:04:55Z

src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/boss_meathook.cpp

@@ -71,7 +87,7 @@ class boss_meathook : public CreatureScript
            Talk(SAY_SLAY);
        }



+void WaypointReached(uint32 waypointId) { }

PkllonG · 2020-06-28T23:12:49Z

src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/boss_salramm.cpp

@@ -47,14 +48,28 @@ class boss_salramm : public CreatureScript

    CreatureAI* GetAI(Creature* creature) const
    {
-        return new boss_salrammAI (creature);
+        return GetInstanceAI<boss_salrammAI>(creature);


-return GetInstanceAI<boss_salrammAI>(creature);
+return new boss_salrammAI (creature);

PkllonG · 2020-06-28T23:13:08Z

src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/boss_meathook.cpp

@@ -37,14 +39,28 @@ class boss_meathook : public CreatureScript

    CreatureAI* GetAI(Creature* creature) const
    {
-        return new boss_meathookAI (creature);
+        return GetInstanceAI<boss_meathookAI>(creature);


-return GetInstanceAI<boss_meathookAI>(creature);
+return new boss_meathookAI (creature);

Kitzunu · 2020-07-17T14:54:46Z

I will close this as abandoned.
Feel free to reopen whenever someone wants to take it over :)

FALL1N1 added 3 commits June 24, 2018 03:32

Core/Scripts: Meathook and Salramm should patrol once they spawn.

516025d

let's make gcc happy

a762280

we won't need this

54d69d5

BarbzYHOOL added General - NPC labels Jul 4, 2018

BarbzYHOOL added the WIP label Jul 4, 2018

BarbzYHOOL added the Needs Developer label Nov 17, 2018

FrancescoBorzi added PR NOT COMPLETED and removed WIP labels Dec 22, 2018

FrancescoBorzi removed the General - NPC label Jan 28, 2019

fix the build

1481eed

FALL1N1 added 2 commits March 6, 2020 16:10

fix compile #2, make travis happy

58d203c

now...?

eef9afd

Merge remote-tracking branch 'upstream/master' into pr/942

17375b9

PkllonG reviewed Jun 28, 2020

View reviewed changes

Kitzunu closed this Jul 17, 2020

BarbzYHOOL added the WIP label Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core/Scripts: Meathook and Salramm should patrol once they spawn. #942

Core/Scripts: Meathook and Salramm should patrol once they spawn. #942

FALL1N1 commented Jun 24, 2018 •

edited

Loading

FALL1N1 commented Jun 25, 2018 •

edited

Loading

BarbzYHOOL commented Jul 4, 2018

Knindzagxg commented Nov 17, 2018

FrancescoBorzi commented Dec 22, 2018

Si1ker commented Mar 4, 2020 •

edited

Loading

FrancescoBorzi commented Mar 4, 2020

BarbzYHOOL commented Mar 4, 2020

FALL1N1 commented Mar 5, 2020

BarbzYHOOL commented Mar 5, 2020

Si1ker commented Mar 6, 2020 •

edited

Loading

FALL1N1 commented Mar 6, 2020

BarbzYHOOL commented Mar 6, 2020

FALL1N1 commented Mar 6, 2020

Si1ker commented Mar 9, 2020 •

edited

Loading

FALL1N1 commented Mar 9, 2020

BarbzYHOOL commented Mar 9, 2020

FrancescoBorzi commented Mar 9, 2020

BarbzYHOOL commented Mar 9, 2020 •

edited

Loading

PkllonG Jun 28, 2020 •

edited

Loading

PkllonG Jun 28, 2020

PkllonG Jun 28, 2020 •

edited

Loading

PkllonG Jun 28, 2020

PkllonG Jun 28, 2020 •

edited

Loading

PkllonG Jun 28, 2020

PkllonG Jun 28, 2020

PkllonG Jun 28, 2020

Kitzunu commented Jul 17, 2020

		@@ -103,7 +118,7 @@ class boss_salramm : public CreatureScript
		}
		}

		@@ -71,7 +87,7 @@ class boss_meathook : public CreatureScript
		Talk(SAY_SLAY);
		}

Core/Scripts: Meathook and Salramm should patrol once they spawn. #942

Core/Scripts: Meathook and Salramm should patrol once they spawn. #942

Conversation

FALL1N1 commented Jun 24, 2018 • edited Loading

FALL1N1 commented Jun 25, 2018 • edited Loading

BarbzYHOOL commented Jul 4, 2018

Knindzagxg commented Nov 17, 2018

FrancescoBorzi commented Dec 22, 2018

Si1ker commented Mar 4, 2020 • edited Loading

FrancescoBorzi commented Mar 4, 2020

BarbzYHOOL commented Mar 4, 2020

FALL1N1 commented Mar 5, 2020

BarbzYHOOL commented Mar 5, 2020

Si1ker commented Mar 6, 2020 • edited Loading

FALL1N1 commented Mar 6, 2020

BarbzYHOOL commented Mar 6, 2020

FALL1N1 commented Mar 6, 2020

Si1ker commented Mar 9, 2020 • edited Loading

FALL1N1 commented Mar 9, 2020

BarbzYHOOL commented Mar 9, 2020

FrancescoBorzi commented Mar 9, 2020

BarbzYHOOL commented Mar 9, 2020 • edited Loading

PkllonG Jun 28, 2020 • edited Loading

Choose a reason for hiding this comment

PkllonG Jun 28, 2020

Choose a reason for hiding this comment

PkllonG Jun 28, 2020 • edited Loading

Choose a reason for hiding this comment

PkllonG Jun 28, 2020

Choose a reason for hiding this comment

PkllonG Jun 28, 2020 • edited Loading

Choose a reason for hiding this comment

PkllonG Jun 28, 2020

Choose a reason for hiding this comment

PkllonG Jun 28, 2020

Choose a reason for hiding this comment

PkllonG Jun 28, 2020

Choose a reason for hiding this comment

Kitzunu commented Jul 17, 2020

FALL1N1 commented Jun 24, 2018 •

edited

Loading

FALL1N1 commented Jun 25, 2018 •

edited

Loading

Si1ker commented Mar 4, 2020 •

edited

Loading

Si1ker commented Mar 6, 2020 •

edited

Loading

Si1ker commented Mar 9, 2020 •

edited

Loading

BarbzYHOOL commented Mar 9, 2020 •

edited

Loading

PkllonG Jun 28, 2020 •

edited

Loading

PkllonG Jun 28, 2020 •

edited

Loading

PkllonG Jun 28, 2020 •

edited

Loading