Update NPC text IDs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
|
Yeah, no need for testing BUT I know several malls use 50000 as a base Maybe we should use something else, like 49000 or 49999 (by the way you can merge on this repository too) |
|
ok you can merge |
Winfidonarleyan
approved these changes
Jan 23, 2019
ghost
merged commit
|
hmm in fact it should be 499999, sorry I confused 500000 is the base of several big malls, with tons of NPCs |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change NPC text IDs from 50000 to 500000 and 50001 to 500001 due to a conflict with AC commit azerothcore/azerothcore-wotlk@b34bc28 which uses 50000 and 50001 for other purposes.
Tested build and in-game on Ubuntu 16.04.