Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more color code formats #50

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Conversation

Dakta
Copy link

@Dakta Dakta commented Jun 5, 2018

Support a broader range of typical color control sequences (with optional leading 0's).

The "standard" for ANSI control sequences allows optional leading 0, which can be multiple. This patch adds support and should enable functionality on a wider range of colorized terminal output.

Support a broader range of typical color control sequences (with optional leading `0`'s).
@@ -1,34 +1,34 @@
{
"ANSI_FG": [
{"scope": "black", "code": "\\x1b\\[(0;)?30m", "color": "#000000"},
{"scope": "black", "code": "\\x1b\\[30m", "color": "#000000"},
Copy link
Collaborator

@jfcherng jfcherng Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? This modification looks different from others.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I mangled one entry with find and replace, good catch, fixed.

Looks like find and replace had some trouble with this line.
@jfcherng jfcherng merged commit 629d9a5 into aziz:master Jun 5, 2018
@jfcherng
Copy link
Collaborator

jfcherng commented Jun 5, 2018

Thank you. 👍

@Dakta Dakta deleted the iTerm-OSX-compatible branch June 5, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants