Avoid re-inventing wheels with null output streams.

I'm pretty sure that there's at least one of these in our own codebase too.
babymechanic · Apr 11, 2017 · 7ba1186 · 7ba1186
1 parent 6c7b4b4
commit 7ba1186
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java b/java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java
@@ -22,6 +22,7 @@
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
+import com.google.common.io.ByteStreams;
 
 //import org.apache.commons.io.output.NullOutputStream;
 import org.openqa.selenium.WebDriverException;
@@ -135,6 +136,7 @@ protected GeckoDriverService createDriverService(File exe, int port,
       try {
         GeckoDriverService service = new GeckoDriverService(exe, port, args, environment);
         if (getLogFile() !=  null) {
+          // TODO: This stream is leaked.
           service.sendOutputTo(new FileOutputStream(getLogFile()));
         } else {
           String firefoxLogFile = System.getProperty(FirefoxDriver.SystemProperty.BROWSER_LOGFILE);
@@ -144,12 +146,9 @@ protected GeckoDriverService createDriverService(File exe, int port,
             } else if ("/dev/stderr".equals(firefoxLogFile)) {
               service.sendOutputTo(System.err);
             } else if ("/dev/null".equals(firefoxLogFile)) {
-              service.sendOutputTo(new OutputStream() {
-                @Override
-                public void write(int b) throws IOException {
-                }
-              });
+              service.sendOutputTo(ByteStreams.nullOutputStream());
             } else {
+              // TODO: The stream is leaked.
               service.sendOutputTo(new FileOutputStream(firefoxLogFile));
             }
           }