Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for Release server-2022-04-01 #7788

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 1, 2022

Changelog for Release server-2022-04-01

@github-actions github-actions bot added the release PRs with this label will create a tag when merged label Apr 1, 2022
@shields-cd shields-cd had a problem deploying to shields-staging-pr-7788 April 1, 2022 01:36 Failure
@shields-ci
Copy link

Messages
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

📖

✨ Thanks for your contribution to Shields, @github-actions[bot]!

Generated by 🚫 dangerJS against 6f03524

@calebcartwright
Copy link
Member

Quite puzzled by the CI failure for the package 🤔

@calebcartwright
Copy link
Member

Whatever this is it seems to be impacting all PRs, though I'm unable to reproduce it locally

@calebcartwright
Copy link
Member

calebcartwright commented Apr 1, 2022

Okay looks like this is an upstream issue an npm npm/cli#4664 as apparently the Circle 14 image is using npm 8.6.0

@calebcartwright
Copy link
Member

As I see we've got a few options:

  • bury our heads in the sand by pinning to npm 8.5.5
  • mostly bury our heads in the sand by adding the --legacy-peer-deps to relevant places in CI and project documentation
  • give ourselves headaches by trying to unwind all the legacy peer references in the lockfile.

I started down the latter path but gave up fairly quickly

@chris48s
Copy link
Member

chris48s commented Apr 2, 2022

Bah. My hope was that --strict-peer-deps should have been protecting us against this, but bugs happen sometime, even in npm 🤷

I think we should aim for the project to be installable on latest NPM. I have submitted a PR at #7809 which gets the build passing by downgrading eslint-plugin-promise. When eslint-plugin-standard 17.0.0 is released we will be able to upgrade it again. That was the only conflict as far as I can see. Lets get that one merged, rebase everything on to it and see where we are..

@calebcartwright
Copy link
Member

That was the only conflict as far as I can see

Oh maybe some of what I experienced was self-inflicted. I think at one point I had deleted the lockfile locally, and then trying to do installs afterwards with 8.6.0 was a tangle of peer dependency issues

@chris48s
Copy link
Member

chris48s commented Apr 3, 2022

Well, all of this is self-inflicted on some level 😆

I'm going to close this one off for now. I'll trigger another release PR when we've worked our way through this week's dependency bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release PRs with this label will create a tag when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants