Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split collection manager from user repo #185

Merged
merged 12 commits into from
Jun 26, 2022

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 26, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #185 (84a1cef) into master (3796a40) will increase coverage by 0.73%.
The diff coverage is 51.30%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   46.53%   47.27%   +0.73%     
==========================================
  Files          95       96       +1     
  Lines        5546     5544       -2     
==========================================
+ Hits         2581     2621      +40     
+ Misses       2702     2653      -49     
- Partials      263      270       +7     
Impacted Files Coverage Δ
internal/model/subject_type.go 0.00% <0.00%> (ø)
internal/user/mysql_repository.go 42.85% <ø> (+14.40%) ⬆️
internal/web/handler/query_parse.go 29.33% <0.00%> (-6.16%) ⬇️
internal/web/res/user.go 89.47% <ø> (ø)
main.go 0.00% <ø> (ø)
internal/web/handler/collection.go 29.29% <35.71%> (+6.97%) ⬆️
internal/collection/mysql_repo.go 64.55% <64.55%> (ø)
internal/test/web.go 91.01% <100.00%> (+0.05%) ⬆️
internal/web/handler/new.go 75.40% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3796a40...84a1cef. Read the comment docs.

@trim21 trim21 marked this pull request as ready for review June 26, 2022 22:00
@trim21 trim21 merged commit 8485ad6 into bangumi:master Jun 26, 2022
@trim21 trim21 deleted the refactor/collection-repo branch June 26, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant