Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move timeline to micro service #273

Merged
merged 14 commits into from
Dec 31, 2022
Merged

refactor: move timeline to micro service #273

merged 14 commits into from
Dec 31, 2022

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Dec 31, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Base: 45.86% // Head: 42.46% // Decreases project coverage by -3.40% ⚠️

Coverage data is based on head (0ca60fd) compared to base (114155b).
Patch coverage: 3.86% of modified lines in pull request are covered.

❗ Current head 0ca60fd differs from pull request most recent head c342f22. Consider uploading reports for the commit c342f22 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   45.86%   42.46%   -3.41%     
==========================================
  Files         232      220      -12     
  Lines       10214    10286      +72     
==========================================
- Hits         4685     4368     -317     
- Misses       4965     5376     +411     
+ Partials      564      542      -22     
Impacted Files Coverage Δ
cmd/gen/gorm/main.go 0.00% <ø> (ø)
config/config.go 0.00% <ø> (ø)
dal/query/gen.go 71.11% <ø> (-0.09%) ⬇️
generated/proto/go/api/v1/timeline_grpc.pb.go 0.00% <0.00%> (ø)
internal/timeline/grpc.go 0.00% <0.00%> (ø)
generated/proto/go/api/v1/timeline.pb.go 4.00% <4.00%> (ø)
ctrl/update_subject_collection.go 59.22% <100.00%> (-1.33%) ⬇️
internal/model/type.go 78.57% <100.00%> (-6.05%) ⬇️
internal/pkg/null/type.go 0.00% <0.00%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trim21 trim21 merged commit c160d6a into bangumi:master Dec 31, 2022
@trim21 trim21 deleted the grpc branch January 5, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant