Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create python 3.7.3 Dockerfile #1

Merged
merged 4 commits into from
Jul 22, 2019
Merged

Create python 3.7.3 Dockerfile #1

merged 4 commits into from
Jul 22, 2019

Conversation

winterjung
Copy link
Contributor

@winterjung winterjung commented Jul 19, 2019

  • 본 PR 머지 후 repo public 전환하려 합니다
  • 참고한 레퍼런스
  • 3.7.4로 할지 3.7.3으로 할지 고민했는데 일단 저희가 주로 사용하는 버전으로 골랐습니다.
  • 버전 네이밍을 README에 적었듯 rainist/python-centos:3.7-7로 가져가려하는데 코멘트 부탁드려요
  • RUN Layer를 더 줄이는게 나을까요?
  • 최종 이미지는 506MB 입니다 :kry:

https://rainist.atlassian.net/browse/FDT-172

@winterjung winterjung requested review from 0xd669 and removed request for 0xd669 July 22, 2019 02:47
3.7/centos7/Dockerfile Outdated Show resolved Hide resolved
3.7/centos7/Dockerfile Outdated Show resolved Hide resolved
@winterjung winterjung requested a review from 0xd669 July 22, 2019 11:28
@0xd669
Copy link
Member

0xd669 commented Jul 22, 2019

이 도커 파일에 해당하는 이미지 태그는 다음의 태그들을 모두 지원하는 게 어떨까 싶습니다. (태그 순서는 centos-python 이 뭔가 좋을 것 같으나... 레포명이 python-centos이므로)

  • rainist/python-centos:3.7.3-7
  • rainist/python-centos:3.7.3-7.6.1810

@winterjung
Copy link
Contributor Author

winterjung commented Jul 22, 2019

@sunghyunzz 아예 rainist/python:3.7-centos7, rainist/python:3.7.3-centos7, rainist/python:3.7.3-centos7.6.1810도 나을거같네용. 파이썬 공식 도커허브처럼? 레포 이름도 docker-python같은

@0xd669
Copy link
Member

0xd669 commented Jul 22, 2019

@jungwinter 것두 좋을 것 같네요 👍

@winterjung
Copy link
Contributor Author

@sunghyunzz 해당 사항(레포 리네임, README 수정) 반영했고 로컬에서 빌드 성공 확인했습니다. (travis를 달 필요는 없겠죠?)

Copy link
Member

@0xd669 0xd669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L.G.T.M 💯

@winterjung winterjung merged commit d62d814 into master Jul 22, 2019
@winterjung winterjung deleted the python37-centos7 branch July 22, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants